Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Thanks for this patch.

It seems good to me, I just realized that in the Transaction object there is no check for the nullptr value of the Rule argument, nothing at all. Probably we should add that into the constructor...

Any attempts to create Transaction with null pointer of rules (or invalid pointer) now impossible because segfault will be caused immidiately on line:

m_secXMLParseXmlIntoArgs(rules->m_secXMLParseXmlIntoArgs),

Therefore, in the current implementation, if the object is created and we are not in the constructor, then we can be sure that m_rules is valid. :-) This means that all existing library clients are guaranteed to ensure that the rules pointer is valid. :-)